120 lines
7.5 KiB
Markdown
120 lines
7.5 KiB
Markdown
|
# Contributing to Smarty
|
||
|
|
|
||
|
|
First off, thanks for taking the time to contribute! ❤️
|
||
|
|
|
||
|
|
> And if you like the project, but just don't have time to contribute, that's fine. There are other easy ways to support the project and show your appreciation, which we would also be very happy about:
|
||
|
|
> - Star the project
|
||
|
|
> - Tell a friend about it
|
||
|
|
> - Refer this project in your project's readme
|
||
|
|
> - Mention the project at local meetups and tell your friends/colleagues
|
||
|
|
|
||
|
|
## I Have a Question
|
||
|
|
|
||
|
|
> If you want to ask a question, we assume that you have read the available [Documentation](https://smarty-php.github.io/smarty).
|
||
|
|
|
||
|
|
Before you ask a question, it is best to search for existing [Issues](https://github.com/smarty-php/smarty/issues) that might help you.
|
||
|
|
In case you have found a suitable issue and still need clarification, you can write your question in this issue.
|
||
|
|
It is also advisable to search the internet for answers first.
|
||
|
|
|
||
|
|
If you then still feel the need to ask a question and need clarification, we recommend the following:
|
||
|
|
|
||
|
|
- [Open an Issue](https://github.com/smarty-php/smarty/issues/new).
|
||
|
|
- Provide as much context as you can about what you're running into.
|
||
|
|
- Provide Smarty and PHP versions
|
||
|
|
|
||
|
|
We will then take care of the issue as soon as possible.
|
||
|
|
|
||
|
|
## I Want To Contribute
|
||
|
|
|
||
|
|
> ### Legal Notice
|
||
|
|
> When contributing to this project, you must agree that you have authored 100% of the content,
|
||
|
|
> that you have the necessary rights to the content and that the content you contribute may be provided under the project license.
|
||
|
|
|
||
|
|
### Reporting Bugs
|
||
|
|
|
||
|
|
#### Before Submitting a Bug Report
|
||
|
|
|
||
|
|
A good bug report shouldn't leave others needing to chase you up for more information. Therefore, we ask you to
|
||
|
|
investigate carefully, collect information and describe the issue in detail in your report. Please complete the
|
||
|
|
following steps in advance to help us fix any potential bug as fast as possible.
|
||
|
|
|
||
|
|
- Make sure that you are using the latest version.
|
||
|
|
- Determine if your bug is really a bug and not an error on your side. (Make sure that you have read the [documentation](https://smarty-php.github.io/smarty). If you are looking for support, you might want to check [this section](#i-have-a-question)).
|
||
|
|
- To see if other users have experienced (and potentially already solved) the same issue you are having, check if there is not already a bug report existing for your bug or error in the [bug tracker](https://github.com/smarty-php/smarty/issues?q=label%3Abug).
|
||
|
|
- Also make sure to search the internet (including Stack Overflow) to see if users outside of the GitHub community have discussed the issue.
|
||
|
|
- Collect information about the bug:
|
||
|
|
- For an Exception: please provide the Stack trace
|
||
|
|
- OS (Windows, Linux, macOS)
|
||
|
|
- PHP version
|
||
|
|
- Smarty version
|
||
|
|
- A minimal snippet of (your) code that triggers the bug
|
||
|
|
- Expected output versus actual output
|
||
|
|
- Can you reliably reproduce the issue? And can you also reproduce it with older versions?
|
||
|
|
|
||
|
|
#### How Do I Submit a Good Bug Report?
|
||
|
|
|
||
|
|
> You must never report security related issues, vulnerabilities or bugs including sensitive information to the issue tracker, or elsewhere in public.
|
||
|
|
> For sensitive bugs, please see [SECURITY.md](SECURITY.md).
|
||
|
|
|
||
|
|
We use GitHub issues to track bugs and errors. If you run into an issue with the project:
|
||
|
|
|
||
|
|
- Open an [Issue](https://github.com/smarty-php/smarty/issues/new). (Since we can't be sure at this point whether it is a bug or not, we ask you not to talk about a bug yet and not to label the issue.)
|
||
|
|
- Explain the behavior you would expect and the actual behavior.
|
||
|
|
- Please provide as much context as possible and describe the *reproduction steps* that someone else can follow to recreate the issue on their own. This usually includes your code. For good bug reports you should isolate the problem and create a reduced test case.
|
||
|
|
- Provide the information you collected in the previous section.
|
||
|
|
|
||
|
|
Once it's filed:
|
||
|
|
|
||
|
|
- The project team will label the issue accordingly.
|
||
|
|
- A team member will try to reproduce the issue with your provided steps. If there are no reproduction steps or no obvious way to reproduce the issue, the team will ask you for those steps and mark the issue as `needs-repro`. Bugs with the `needs-repro` tag will not be addressed until they are reproduced.
|
||
|
|
- If the team is able to reproduce the issue, it will be marked `needs-fix`, as well as possibly other tags (such as `critical`), and the issue will be left to be implemented by someone.
|
||
|
|
|
||
|
|
|
||
|
|
|
||
|
|
### Suggesting Enhancements
|
||
|
|
|
||
|
|
This section guides you through submitting an enhancement suggestion for CONTRIBUTING.md, **including completely new features and minor improvements to existing functionality**. Following these guidelines will help maintainers and the community to understand your suggestion and find related suggestions.
|
||
|
|
|
||
|
|
|
||
|
|
#### Before Submitting an Enhancement
|
||
|
|
|
||
|
|
- Make sure that you are using the latest version.
|
||
|
|
- Read the [documentation](https://smarty-php.github.io/smarty) carefully and find out if the functionality is already covered, maybe by an individual configuration.
|
||
|
|
- Perform a [search](https://github.com/smarty-php/smarty/issues) to see if the enhancement has already been suggested. If it has, add a comment to the existing issue instead of opening a new one.
|
||
|
|
- Find out whether your idea fits with the scope and aims of the project. It's up to you to make a strong case to convince the project's developers of the merits of this feature. Keep in mind that we want features that will be useful to the majority of our users and not just a small subset. If you're just targeting a minority of users, consider writing an add-on/plugin library.
|
||
|
|
|
||
|
|
|
||
|
|
#### How Do I Submit a Good Enhancement Suggestion?
|
||
|
|
|
||
|
|
Enhancement suggestions are tracked as [GitHub issues](https://github.com/smarty-php/smarty/issues).
|
||
|
|
|
||
|
|
- Use a **clear and descriptive title** for the issue to identify the suggestion.
|
||
|
|
- Provide a **step-by-step description of the suggested enhancement** in as many details as possible.
|
||
|
|
- **Describe the current behavior** and **explain which behavior you expected to see instead** and why. At this point you can also tell which alternatives do not work for you.
|
||
|
|
- You may want to **include screenshots and animated GIFs** which help you demonstrate the steps or point out the part which the suggestion is related to. You can use [this tool](https://www.cockos.com/licecap/) to record GIFs on macOS and Windows, and [this tool](https://github.com/colinkeenan/silentcast) or [this tool](https://github.com/GNOME/byzanz) on Linux.
|
||
|
|
- **Explain why this enhancement would be useful** to most CONTRIBUTING.md users. You may also want to point out the other projects that solved it better and which could serve as inspiration.
|
||
|
|
|
||
|
|
|
||
|
|
### Improving The Documentation
|
||
|
|
|
||
|
|
The [docs](docs/index.md) are written in markdown, configured in [mkdocs.yml](mkdocs.yml) and published
|
||
|
|
to [GitHub pages](https://smarty-php.github.io/smarty) using [mkdocs](https://www.mkdocs.org/) and [mike](https://github.com/jimporter/mike).
|
||
|
|
|
||
|
|
To preview the docs while you are writing, run:
|
||
|
|
```bash
|
||
|
|
mkdocs serve
|
||
|
|
```
|
||
|
|
This should launch a local web server and give you a link to open in your browser.
|
||
|
|
|
||
|
|
When you are finished, commit your changes and provide a [Pull Request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request).
|
||
|
|
|
||
|
|
#### Publishing the docs
|
||
|
|
If you are a maintainer, you can publish the document using [mike](https://github.com/jimporter/mike). Make sure you provide the correct version.
|
||
|
|
|
||
|
|
```bash
|
||
|
|
mike deploy 5.x
|
||
|
|
```
|
||
|
|
|
||
|
|
## Attribution
|
||
|
|
This guide is based on the **contributing.md**. [Make your own](https://contributing.md/)!
|